Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add egg2 vs egg1 #14

Merged
merged 6 commits into from
Nov 17, 2017
Merged

feat: add egg2 vs egg1 #14

merged 6 commits into from
Nov 17, 2017

Conversation

dead-horse
Copy link
Member

No description provided.

@dead-horse dead-horse changed the title [WIP] feat: add egg2 vs egg1 feat: add egg2 vs egg1 Nov 16, 2017
@dead-horse
Copy link
Member Author

@eggjs/core

@fengmk2
Copy link
Member

fengmk2 commented Nov 16, 2017

LGTM!

@popomore popomore mentioned this pull request Nov 16, 2017
Closed
29 tasks
@dead-horse
Copy link
Member Author

image

@fengmk2
Copy link
Member

fengmk2 commented Nov 16, 2017

meta 中间件为何这么热。。。 https:/eggjs/egg/blob/master/app/middleware/meta.js#L11

@fengmk2
Copy link
Member

fengmk2 commented Nov 16, 2017

randomBytes 也改改，使用一个简单的

@dead-horse
Copy link
Member Author

csrf 由于正常访问不会一直设置 cookie，所以先在压测时关掉了，关掉后再测试更新一下结果

@dead-horse
Copy link
Member Author

csrf 关闭后性能和 koa 的差距已经很近了

@dead-horse
Copy link
Member Author

image

egg 还有 meta 这个热点，其他的都是 http / koa / koa-compose 中的

@dead-horse
Copy link
Member Author

meta 和 createContext 的热点都是由 Date.now() 带来的，6% 左右的性能消耗。

@dead-horse
Copy link
Member Author

image

@dead-horse dead-horse merged commit a58b50e into master Nov 17, 2017
@dead-horse dead-horse deleted the egg2-vs-egg1 branch November 17, 2017 18:07
@atian25 atian25 mentioned this pull request Jun 29, 2022
Closed
@atian25 atian25 mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dead-horse @fengmk2